[lex] P2314r4 fixes #5040
Merged
[lex] P2314r4 fixes #5040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paper asks to delete this paragraph. The paper adds a paragraph that starts similarly, but makes no mention of the null character. So move the index entries further below, where the new wording seems to match in intent.
jensmaurer
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
@tkoeppe, this fixes misapplications of P2314R4 and should go in ASAP.
It might be helpful to refer to P2314R4 in the commit descriptions where material oversights are fixed (missing "R" for string literal, deleted "phase 6" paragraph).
|
Yes, thanks, will do after the motions. I'll squash this into one commit, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see https://github.com/cplusplus/draft/pull/5004/files#r732300134.