P2502R2 std::generator: Synchronous Coroutine Generator for Ranges #5695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
suggested changes
Jul 31, 2022
There was a problem hiding this comment.
After applying the suggested changes, replace all Rng with R and all rng with r.
The only uses of rng in the standard come from InnerRng and their related InnerConstRng and inner_rng, and [rand.req.urng].
R is more common for ranges::range and its refinements.
CaseyCarter
suggested changes
Aug 1, 2022
source/ranges.tex
Outdated
| \pnum | ||
| \returns | ||
| An awaitable object of an unspecified type\iref{expr.await} | ||
| which takes ownership of the generator \tcode{g.range}, |
There was a problem hiding this comment.
I think
Suggested change
| which takes ownership of the generator \tcode{g.range}, | |
| into which \tcode{g.range} is moved, |
communicates the same point, perhaps even more clearly?
jensmaurer
force-pushed
the
motions-2022-07-lwg-32
branch
from
f4af5b0 to
e75e167
Compare
JohelEGP
suggested changes
Aug 7, 2022
jensmaurer
force-pushed
the
motions-2022-07-lwg-32
branch
from
abfcdf3 to
600b95a
Compare
Mick235711
suggested changes
Aug 8, 2022
tkoeppe
force-pushed
the
motions-2022-07-lwg-32
branch
2 times, most recently
from
37e68d6 to
52456b9
Compare
It is more customary to refer to ranges as just "R", not "Rng".
tkoeppe
force-pushed
the
motions-2022-07-lwg-32
branch
from
692a231 to
3dee233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5619
Fixes cplusplus/papers#1151