Skip to content

[Motion lwg 1] P2910R0 C++ Standard Library Issues #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 16, 2023
Merged

[Motion lwg 1] P2910R0 C++ Standard Library Issues #6335

merged 16 commits into from
Jul 16, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Jun 21, 2023 •
edited by jensmaurer
Loading

Fixes #6287.

Note: LWG3887 skipped - already fixed.

Fixes cplusplus/papers#1612
Also fixes #6151
Also fixes #4431

@burblebee burblebee marked this pull request as ready for review June 21, 2023 21:43
jwakely
jwakely approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

JohelEGP
JohelEGP approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using https://isocpp.org/files/papers/P2910R0.html.

Note: LWG3887 skipped - already fixed.

For the record, the commit that fixed it is 6e7fd98.

@jensmaurer jensmaurer added this to the post-2023-06 milestone Jun 27, 2023
burblebee added 16 commits July 16, 2023 22:54
@burblebee @tkoeppe
LWG2994 Needless UB for basic_string and basic_string_view
051d17d
@burblebee @tkoeppe
LWG3884 flat_foo is missing allocator-extended copy/move constructors
03da5ba
@burblebee @tkoeppe
LWG3885 'op' should be in [zombie.names]
aa4dd77
@burblebee @tkoeppe
LWG3893 LWG 3661 broke atomic<shared_ptr<T>> a; a = nullptr;
e25a755
@burblebee @tkoeppe
LWG3894 generator::promise_type::yield_value(ranges::elements_of<Rng,…
8f03433 
… Alloc>) should not be noexcept
@burblebee @tkoeppe
LWG3903 span destructor is redundantly noexcept
0ce8706
@burblebee @tkoeppe
LWG3904 lazy_split_view::outer-iterator's const-converting constructo…
fe5702c 
…r isn't setting trailing_empty_
@burblebee @tkoeppe
LWG3905 Type of std::fexcept_t
b4e5007
@burblebee @tkoeppe
LWG3912 enumerate_view::iterator::operator- should be noexcept
e45205c
@burblebee @tkoeppe
LWG3914 Inconsistent template-head of ranges::enumerate_view
6ed8e7a
@burblebee @tkoeppe
LWG3915 Redundant paragraph about expression variations
0c3b530
@burblebee @tkoeppe
LWG3925 Concept formattable's definition is incorrect
32acefa
@burblebee @tkoeppe
LWG3927 Unclear preconditions for operator[] for sequence containers
90dc5f0
@burblebee @tkoeppe
LWG3935 template<class X> constexpr complex& operator=(const complex<…
c0579dd 
…X>&) has no specification
@burblebee @tkoeppe
LWG3938 Cannot use std::expected monadic ops with move-only error_type
756d2ca
@burblebee @tkoeppe
LWG3940 std::expected<void, E>::value() also needs E to be copy const…
14eb0ae 
…ructible
@tkoeppe tkoeppe force-pushed the motions-2023-06-lwg-1 branch from 5e4457d to 14eb0ae Compare July 16, 2023 21:54
@tkoeppe tkoeppe merged commit c89ceed into main Jul 16, 2023
@jensmaurer jensmaurer deleted the motions-2023-06-lwg-1 branch November 12, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

+1 more reviewer

@JohelEGP JohelEGP JohelEGP approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2023-06
5 participants
@burblebee @jwakely @JohelEGP @tkoeppe @jensmaurer