[alg.ends.with]: drop_view should be views::drop #6773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quuxplusone
force-pushed
the
views-meow
branch
from
794b2f7 to
4eca14b
Compare
|
Updated (thanks Tim). The EDIT: ...oh, unless the user-facing spelling is simply |
Move-only views are not necessarily input-only. |
We don't want programmers doing CTAD on `ranges::drop_view(args...)`, so we shouldn't put it in the as-if-by code either. What we expect people to do (and what we intend vendors to do here) is `views::drop`. Tim Song points out that when `r1` is a move-only view such as an `owning_view`, then `views::drop(r1, N)` alone is ill-formed because `views::all(r1)` is ill-formed. We have to manually wrap the argument `r1` in a `ranges::ref_view` (for which there is no user-facing name) in order to handle `owning_view` correctly.
jwakely
approved these changes
May 20, 2024
jensmaurer
approved these changes
May 20, 2024
jensmaurer
pushed a commit
to jensmaurer/draft
that referenced
this pull request
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want programmers doing CTAD on
ranges::drop_view(args...), so we shouldn't put it in the as-if-by code either. What we expect people to do (and what we intend vendors to do here) isviews::drop.(Compare #6373. I'm also pinging the LWG reflector for an opinion on whether this is handleable without an LWG issue.)