[lex.charset] Extract universal-character-name grammar to new subclause #7067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
requested changes
Jun 17, 2024
AlisdairM
force-pushed
the
lex_universal_char
branch
from
2e3d266 to
86f0559
Compare
AlisdairM
force-pushed
the
lex_universal_char
branch
from
86f0559 to
f1105c1
Compare
jensmaurer
requested changes
Sep 28, 2024
AlisdairM
force-pushed
the
lex_universal_char
branch
from
f1105c1 to
15b7a2a
Compare
|
Squashed all three commits into one, and update the commit message as requested. |
|
The commit message still says [lax.char]. Note the laxative there. |
|
@tkoeppe, I think this is reasonable and should go in. Feel free to fix the commit message when merging. |
…nd UCNs The grammar for universal-character-name is oddly sandwiched into the middle of the subcluase talking about the different character sets used by the standard. To improve the flow, extract that grammar into its own subclause. In the extraction, I make three other clarifying changes. First, describe this new subclause as 'a way to name any element of the of the translation character set using just the basic character set' rather than simply 'a way to name other characters'. Then, merge the sentence on where universal characters are prohibited into the new intro sentence describing universal characters, to make clear that there is no contradiction between nominating a character, and how that character can be used. Finally, remove the 'one of' in the grammar where there is only one option to choose.
AlisdairM
force-pushed
the
lex_universal_char
branch
from
15b7a2a to
d5e4828
Compare
|
Sorry, force-pushed a fix to the commit message; no other changes |
jensmaurer
approved these changes
Sep 30, 2024
|
@tkoeppe , ping? |
|
@jensmaurer Are you OK with striking the "one of" from the grammar? |
|
@tkoeppe , yes. "One of any member..." makes no sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grammar for universal-character-name is oddly sandwiched into the middle of the subcluase talking about the different character sets used by the standard. To improve the flow, extract that grammar into its own subclause.
In the extraction, I make two other clarifying changes. First, describe this new subclause as 'a way to name any element of the of the tranlation character set using just the basic character set' rather than simply 'a way to name other characters'. Secondly, remove the 'one of' in the grammar where there is only one option to choose.