Skip to content

[LWG motion 10] P2075R6 Philox as an extension of the C++ RNG engines #7123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 22, 2024
Merged

[LWG motion 10] P2075R6 Philox as an extension of the C++ RNG engines #7123

merged 9 commits into from
Jul 22, 2024

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Jul 9, 2024 •
edited
Loading

@burblebee burblebee marked this pull request as ready for review July 9, 2024 04:38
@burblebee burblebee requested review from jwakely and removed request for jwakely July 9, 2024 20:34
@tkoeppe tkoeppe force-pushed the motions-2024-06-lwg-10 branch 5 times, most recently from 84d1ad3 to dc6e9b4 Compare July 17, 2024 23:07
@tkoeppe tkoeppe requested a review from jwakely July 17, 2024 23:13
jwakely
jwakely reviewed Jul 18, 2024
View reviewed changes
@tkoeppe tkoeppe requested review from jwakely and iburyl July 19, 2024 22:11
burblebee and others added 9 commits July 22, 2024 13:10
@burblebee @tkoeppe
P2075R6 Philox as an extension of the C++ RNG engines
f6256f1 
Editorial notes (all in [rand.eng.philox]):
* Omit colon before "long sentence" list in p1.
* Use ":=" to denote definitions (of $Z$ and $key^q_k$).
@tkoeppe
[rand.eng.philox] Change "n-length sequence" to "length-n sequence".
e6e5cad
@tkoeppe
[rand.eng.philox] Improve descriptions of $Y$ and $i$
f9f7ef9
@tkoeppe
[rand.eng.philox] Harmonize description of sequenced variable
7dad0db
@tkoeppe
[rand.eng.philox] $M_k$ and $C_k$ are individual array elements, not …
e19a6e7 
…an entire sequence
@tkoeppe
[rand.eng.philox] Change $f$ to $f_n$, since it depends on $n$.
b3d0322
@tkoeppe
[rand.eng.philox] Replace repetitive note with reference to earlier t…
e548b90 
…ext.
@tkoeppe
[rand.eng.philox] Move description of the key sequence $K$ up to its …
0597a26 
…first mention
@tkoeppe
[rand.eng.philox] Replace "the function f(x) returns" with "f(x) is".
e2565b6
@tkoeppe tkoeppe force-pushed the motions-2024-06-lwg-10 branch from 2c2f592 to e2565b6 Compare July 22, 2024 12:12
@tkoeppe tkoeppe self-requested a review July 22, 2024 12:14
tkoeppe
tkoeppe approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@tkoeppe tkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is now workable.

@tkoeppe tkoeppe merged commit e12cbde into main Jul 22, 2024
@jensmaurer jensmaurer deleted the motions-2024-06-lwg-10 branch November 24, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe approved these changes

@jwakely jwakely Awaiting requested review from jwakely

@iburyl iburyl Awaiting requested review from iburyl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2024-06 LWG Motion 10] P2075R6 Philox as an extension of the C++ RNG engines P2075 R6 Philox as an extension of the C++ RNG engines
4 participants
@burblebee @jwakely @tkoeppe @iburyl