Fix incorrect variable references #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two move operations for the allocators refer to `a` or `a1`, though the code uses `u`. Fix the description to match the code. Also, change the phrase "equals" to "is equal to", which matches other uses in the standard (see [unique.ptr]/4.1 for an example).
| post: \tcode{Y(a) == b}, \tcode{a == X(b)} & \\ \rowsep | ||
|
|
||
| \tcode{X u(std::move(a));} \br | ||
| \tcode{X u = std::move(a);} & |
There was a problem hiding this comment.
Can you also fix the two similar cases above (X u = a; and X u(b);)?
FrankHB
pushed a commit
to FrankHB/draft
that referenced
this pull request
Jul 9, 2016
…#727) Two move operations for the allocators refer to `a` or `a1`, though the code uses `u`. Fix the description to match the code. Also, change the phrase "equals" to "is equal to", which matches other uses in the standard (see [unique.ptr]/4.1 for an example).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two move operations for the allocators refer to
aora1, though the code usesu. Fix the description to match the code.Also, change the phrase "equals" to "is equal to", which matches other uses in the standard (see [unique.ptr]/4.1 for an example).