[stoptoken.concepts] Remove redundant 'swappable<Token>' clause from 'stoppable_token' concept #7299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'stoppable_token' concept The `stoppable_token<Token>` concept requires both `copyable<Token>` to be satisfied and `swappable<Token>` to be satisfied. However, the `copyable<Token>` requirement already subsumes `movable<Token>`, which subsumes `swappable<Token>`. Therefore the requirement for `swappable<Token>` can be removed from the `stoppable_token` concept definition with no semantic change.
jensmaurer
approved these changes
Oct 11, 2024
|
@jwakely , what do you think? |
CaseyCarter
approved these changes
Oct 11, 2024
jwakely
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stoppable_token<Token>concept requires bothcopyable<Token>to be satisfied andswappable<Token>to be satisfied.However, the
copyable<Token>requirement already subsumesmovable<Token>, which subsumesswappable<Token>.Therefore the requirement for
swappable<Token>can be removed from thestoppable_tokenconcept definition with no semantic change.