Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG3810 CTAD for std::basic_format_args #1368

Closed
jwakely opened this issue Nov 21, 2022 · 4 comments · Fixed by cplusplus/draft#6116
Closed

LWG3810 CTAD for std::basic_format_args #1368

jwakely opened this issue Nov 21, 2022 · 4 comments · Fixed by cplusplus/draft#6116
Labels
C++23 Targeted at C++23 format IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Milestone
2023-02

Comments

@jwakely
Copy link
Member

jwakely commented Nov 21, 2022 •
edited by brycelelbach

https://cplusplus.github.io/LWG/issue3810

LWG would like design guidance here. Should CTAD work? It's currently sort-of implied it should, but only if you assume that the exposition-only types and constructors are implemented exactly as shown. If the format-arg-store-type is defined as a nested type of basic_format_args (as in libstdc++) then it doesn't work.

There's an example from Tomasz in the issue showing a case where CTAD might be useful, but Victor suggested we should explicitly disable CTAD here, because it makes it easier to create dangling references.
@jwakely jwakely added the LEWG Library Evolution label Nov 21, 2022
@brycelelbach brycelelbach added C++23 Targeted at C++23 B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting size - small paper size estimate labels Jan 6, 2023
@brycelelbach
Copy link

2023-01-10 Library Evolution Telecon

LWG3810: CTAD for basic_format_args

2023-01-10 Library Evolution Telecon Minutes

Chair: Bryce Adelstein Lelbach

Minute Taker: Ben Craig

Start: 2023-01-10 11:58 Eastern

POLL: Send the proposed resolution to LWG3810 (CTAD for basic_format_args) to Library for C++23, to be confirmed by a Library Evolution electronic poll.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
0 8 0 0 0

Attendance: 13

# of Authors: 0

Author Position: N/A

Outcome: Unanimous consensus in favor.

End: 12:01

Next Steps

Take a Library Evolution electronic poll to send the proposed resolution to LWG3810 (CTAD for basic_format_args) to Library for C++23.

@brycelelbach brycelelbach added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 labels Jan 17, 2023
@brycelelbach brycelelbach added this to the 2023 Telecons milestone Jan 17, 2023
@brycelelbach
Copy link

We only have two C++23 papers that need electronic polling, and both were non-controversial. I'm going to send this directly to Library.

@brycelelbach brycelelbach added LWG Library and removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll labels Jan 24, 2023
@jensmaurer jensmaurer modified the milestones: 2023 Telecons, 2023-02 Jan 25, 2023
@JeffGarland
Copy link
Member

poll: approve the resolution for LWG3810 and move to immediate?

https://wiki.edg.com/bin/view/Wg21issaquah2023/LWG3810-202306

F A N
9 0 0

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed size - small paper size estimate labels Feb 7, 2023
@JeffGarland JeffGarland added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Feb 19, 2023
@frederick-vs-ja
Copy link

This should have been fixed by cplusplus/draft#6116.

@jensmaurer jensmaurer mentioned this issue Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 format IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
2023-02 Issaquah LWG Schedule
Status: Ready
Milestone
2023-02
Development

Successfully merging a pull request may close this issue.

[LWG 3] P2790R0 Immediate issues except 3441 cplusplus/draft
5 participants
@brycelelbach @jwakely @JeffGarland @frederick-vs-ja @jensmaurer