Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3154 R0 Deprecating signed character types in iostreams #1804

Open
wg21bot opened this issue Feb 16, 2024 · 5 comments
Open

P3154 R0 Deprecating signed character types in iostreams #1804

wg21bot opened this issue Feb 16, 2024 · 5 comments
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 IS Ship vehicle: IS LEWG Library Evolution size - medium paper size estimate
Milestone

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Feb 16, 2024

P3154R0 Deprecating signed character types in iostreams (Elias Kosunen)

@wg21bot wg21bot added LEWG Library Evolution SG16 Text processing labels Feb 16, 2024
@wg21bot wg21bot added this to the 2024-telecon milestone Feb 16, 2024
@inbal2l inbal2l added IS Ship vehicle: IS B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - medium paper size estimate C++26 Targeted at C++26 labels Feb 16, 2024
@inbal2l
Copy link
Collaborator

inbal2l commented Feb 16, 2024

@tahonermann - can you please look at this first, especially on the breakage aspect? (the paper is a bit light in exploring this).

@tahonermann
Copy link
Collaborator

@tahonermann - can you please look at this first, especially on the breakage aspect? (the paper is a bit light in exploring this).

Yes, will do.

@fdwr

This comment was marked as off-topic.

@tahonermann

This comment was marked as off-topic.

@tahonermann
Copy link
Collaborator

tahonermann commented Mar 22, 2024

SG16 reviewed P3154R0 during it's 2024-03-13 meeting. The following polls were taken.

Poll 1: Recommend reserving signed char and unsigned char for use as integer types, not character types.

  • Attendees: 11 (1 abstention)
    SF F N A SA
    7 2 0 1 0
  • Consensus in favor.

Poll 2: Forward P3154R0 with the suggested modifications to the motivation section to LEWG for C++26.

  • Attendees: 11 (3 abstentions)
    SF F N A SA
    4 2 1 1 0
  • Consensus in favor.

With regard to the first poll, SG16 encourages LEWG to treat these types as integer types within the standard library, at least with regard to reading and writing text. However, LEWG might want to keep in mind the implications of WG14 using unsigned char as the target type for its char8_t type alias and the corresponding compatibility accommodations that have already been adopted via P2513R4 (char8_t Compatibility and Portability Fix). The against vote on this poll was due to a desire to get implementation experience with the proposed deprecations before settling on a recommendation.

With regard to the second poll, the against vote and the abstentions were due to uneasiness with SG16 stating a position on deprecation since the desired remedy for the situation is more of a LEWG concern. The SG16 chair interprets this as a failure on his part to adequately describe his intent with polling to forward the paper (that intent is to indicate that SG16 believes that concerns that fall within SG16's purview are either adequately addressed or appropriately discussed in the paper). The SG16 chair will strive to make such intent more clear in future polls.

Removing the SG16 label, this paper rests in LEWG's good hands.

@tahonermann tahonermann removed the SG16 Text processing label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 IS Ship vehicle: IS LEWG Library Evolution size - medium paper size estimate
Projects
None yet
Development

No branches or pull requests

4 participants