Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0870 A proposal for a type trait to detect narrowing conversions #724

Open
wg21bot opened this issue Jan 18, 2020 · 16 comments
Open

P0870 A proposal for a type trait to detect narrowing conversions #724

wg21bot opened this issue Jan 18, 2020 · 16 comments

Comments

@wg21bot
Copy link
Collaborator

@wg21bot wg21bot commented Jan 18, 2020

P0870R1 A proposal for a type trait to detect narrowing conversions (Giuseppe D'Angelo)

@wg21bot wg21bot added the LEWGI label Jan 18, 2020
@wg21bot wg21bot added this to the 2020-02 milestone Jan 18, 2020
@jfbastien jfbastien added the EWGI label Feb 11, 2020
@theres-waldo theres-waldo added this to Thursday PM in EWG-I Prague Feb 11, 2020
@theres-waldo theres-waldo moved this from Thursday PM to Wednesday PM in EWG-I Prague Feb 12, 2020
@erichkeane
Copy link
Collaborator

@erichkeane erichkeane commented Feb 12, 2020

EWG-I in Prague

Forward D0870R2 to EWG, as we believe that EWGI cannot provide any further useful feedback to the author.

SF F N A SA
5 4 0 0 0

Loading

@erichkeane erichkeane added EWG and removed EWGI labels Feb 12, 2020
@jfbastien jfbastien removed the LEWGI label Feb 13, 2020
@jfbastien jfbastien added this to Friday in EWG Prague Feb 13, 2020
@jfbastien
Copy link
Collaborator

@jfbastien jfbastien commented Feb 14, 2020

EWG Prague Friday afternoon:

D0870R2 A proposal for a type trait to detect narrowing conversions

Send to SG6 Numerics for input.

SF F N A SA
4 4 6 3 0

We have no concerns with this, only send this paper back to us if SG6 or LEWG / LWG / CWG ask.

SF F N A SA
3 13 2 0 0

Loading

@jfbastien jfbastien added SG6 LEWG and removed EWG labels Feb 14, 2020
@brycelelbach
Copy link
Collaborator

@brycelelbach brycelelbach commented Feb 18, 2020

Prague 2020-02 LEWGI Minutes

P0870R1 std::is_narrowing_conversion: Direction Review

Chair: Billy Baker

Champion: Marc Mutz

Minute Taker: David Olsen

Start Review: 2020-02-11 08:39

You mentioned that there are proposed changes to what are narrowing conversions in flight? Do we expect the definition to change again in the future?

Does EWG(I) need to see this?

Start Polling: 9:14

POLL: We should promise more committee time to pursuing P0870, knowing that our time is scarce and this will leave less time for other work.

Strongly For Weakly For Neutral Weakly Against Strongly Against
2 10 2 1 0

Attendance: 20

# of Authors: 1

Author Position: SF

End: 9:16

CONSENSUS: Bring a revision of P0870R1 (std::is_narrowing_conversion) to EWGI for review, and then revise, with the guidance below, and return to LEWGI for further design review.

  • Paper authors are encouraged to provide a better example of an implementation.
  • Paper authors are encouraged to provide a revision history.
  • Paper authors are encouraged to provide additional references in P0870 to papers related to narrowing conversions that were mentioned during the discussion such as P1818.

Loading

@jensmaurer jensmaurer removed this from the 2020-02 milestone Feb 18, 2020
@wg21bot
Copy link
Collaborator Author

@wg21bot wg21bot commented Apr 24, 2020

P0870R2 A proposal for a type trait to detect narrowing conversions (Giuseppe D'Angelo)

Loading

@wg21bot wg21bot added this to the 2020-telecon milestone Apr 24, 2020
@wg21bot
Copy link
Collaborator Author

@wg21bot wg21bot commented May 21, 2020

P0870R3 A proposal for a type trait to detect narrowing conversions (Giuseppe D'Angelo)

Loading

@inbal2l
Copy link
Collaborator

@inbal2l inbal2l commented Aug 30, 2020

Under LEWG ML review (started: 24 Aug 2020)

Loading

@cor3ntin
Copy link
Collaborator

@cor3ntin cor3ntin commented Sep 7, 2020

Mailing list review: 24 August - 7 September 2020
10 participants:

General positive feedback: We think this feature is useful and should be added to the standard.
No comments on the proposed mechanism, but some concerns about the name which is not consistent with the language ( which has no narrowing convertible" notion, and the fact that the current name would be almost always negated.
Slight preference for is_convertible_without_narrowing among the names offered by the author

  1. is_narrowing_convertible
  2. is_convertible_with_narrowing
  3. is_narrowing
  4. is_non_narrowing_convertible
  5. is_nonarrowing_convertible
  6. is_convertible_without_narrowing
  7. is_convertible_no_narrowing
  8. is_non_narrowing

The author is encouraged to add tony tables and more example and propose more names for further bikeshedding on the mailing list.
I think it should then go to a LEWG telecon next.

Loading

@brycelelbach
Copy link
Collaborator

@brycelelbach brycelelbach commented Oct 20, 2020

Marked for LEWG telecon review next.

Loading

@dangelog
Copy link

@dangelog dangelog commented Oct 21, 2020

There's a typo in the October 2020 mailing, P0870R4 is indeed targeting LEWG and SG6, not just SG6. (The paper itself has the correct targets.)

Loading

@brycelelbach
Copy link
Collaborator

@brycelelbach brycelelbach commented Oct 21, 2020

The label in the mailing and on the paper is of no concern; only the label here is normative, and is correct.

Loading

@wg21bot
Copy link
Collaborator Author

@wg21bot wg21bot commented Oct 21, 2020

P0870R4 A proposal for a type trait to detect narrowing conversions (Giuseppe D'Angelo)

Loading

@ben-craig
Copy link
Collaborator

@ben-craig ben-craig commented Mar 19, 2021

P0870R4: A proposal for a type trait to detect narrowing conversions, remaining

P0870R4: A proposal for a type trait to detect narrowing conversions, remaining

2021-03-16 Library Evolution Telecon Minutes

Chair: Ben Craig

Champion: Giuseppe D'Angelo

Minute Taker: Inbal Levi

SUMMARY:
Unsure if this does specifically what users want in the face of user defined conversions. What it actually does is precisely specified though.

We did not have time to drive this discussion to conclusion.

OUTCOME:

POLL: is_convertible_without_narrowing is an acceptable name for this facility.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
14 7 0 0 0

Attendance: 26

# of Authors: 1

Author Position: SF

Outcome: Unanimous Consent

ACTION: none... leaving in the ready-for-library-evolution-meeting-review state. Hopefully we can get a joint Numerics + LEWG meeting to conclude this.

Loading

@brycelelbach
Copy link
Collaborator

@brycelelbach brycelelbach commented Aug 1, 2021

SG6 will look at this first, and they can send it to Library Evolution when they feel it is ready.

Loading

@dangelog
Copy link

@dangelog dangelog commented Oct 23, 2021

Is SG6 going to reconvene anytime soon?

Loading

@jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Oct 23, 2021

@dangelog , please contact the chair of SG6 directly via e-mail; it is not at all obvious whether messages in this issue tracker reach anyone in particular.

Loading

@dangelog
Copy link

@dangelog dangelog commented Oct 23, 2021

Will do; thanks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants