Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch up exceptional flow #8

Open
karnkaul opened this issue Oct 20, 2022 · 0 comments
Open

Patch up exceptional flow #8

karnkaul opened this issue Oct 20, 2022 · 0 comments
Assignees
Milestone

Comments

@karnkaul
Copy link
Member

karnkaul commented Oct 20, 2022

facade uses exceptions in non-happy paths to signal unrecoverable errors. This has been set up properly during application bootstrap but not so much in the update / render loops: there are sprinkles of asserts and // TODOs in some places which need to be fixed.

This issue is only scoped to fixing error-related // TODOs and asserts.

AC:

  1. Areas of code that need to be addressed have been identified and enumerated
  2. Resolutions for contentious / ambiguous fixes have been discussed
  3. // TODOs (relating to errors) and temporary asserts have been refactored
@karnkaul karnkaul added this to the Hello collab milestone Oct 20, 2022
@karnkaul karnkaul mentioned this issue Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants