Incorporate samplers from GLTF data into textures #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace on-demand texture creation with material-based `ColourSpace` decisions. - Remove `TextureProvider`. - Add check for `Id<Camera>` if attached to `Node` being added. - Rename `TestMaterial` to `LitMaterial`.
karnkaul
commented
Oct 22, 2022
| class Texture; | ||
| class Pipeline; | ||
|
|
||
| struct TextureProvider { |
karnkaul
commented
Oct 22, 2022
| }; | ||
|
|
||
| class TestMaterial : public Material { | ||
| class LitMaterial : public Material { |
There was a problem hiding this comment.
Tests have been successful, time to formalize this material
karnkaul
force-pushed
the
karnage/gltf-samplers
branch
from
247958c to
eb6c45a
Compare
Rinzii
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses two broad points:
Bonus!
It appears that the changes here also close #12!
Background
Colour spaces are a complicated rabbit hole, for this PR just being aware that the same image data can be interpreted in two different ways by textures in Vulkan (sRGB vs linear) is sufficient.
Textures were being created on demand because there's no direct way to know whether one should be in sRGB or linear format: this decision was deferred all the way to a
Materialrequesting a texture of the corresponding format at render time. This PR uses the GLTF material spec to encode the desired colour space of each texture in the returned GLTF scene data, which is then used bySceneto create corresponding textures right after parsing that data.Changes
ColourSpacedecisions.TextureProvider.Id<Camera>if attached toNodebeing added.TestMaterialtoLitMaterial.Close #16