Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

Add Vertex, Primitive; draw quad #16

Merged
merged 4 commits into from
Feb 16, 2025
Merged

Add Vertex, Primitive; draw quad #16

merged 4 commits into from
Feb 16, 2025

Conversation

karnkaul
Copy link
Member

Screenshot_20250215_175021

Screenshot_20250215_175039

@karnkaul karnkaul marked this pull request as ready for review February 16, 2025 05:10
@karnkaul karnkaul requested a review from TymianekPL February 16, 2025 05:11
- Use `IResourcePool` abstract interface for public API
- Move individual pool classes to 'src', under `namespace detail`
- Concretize in 'engine.cpp'

This hides unecessary implementation details from users, and reduces includes in the public API.
Copy link
Member

@TymianekPL TymianekPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karnkaul karnkaul enabled auto-merge (squash) February 16, 2025 09:39
@karnkaul karnkaul merged commit 66799bf into main Feb 16, 2025
5 checks passed
@karnkaul karnkaul deleted the karnage/vertices branch February 16, 2025 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants