Skip to content

Update buying_things_for_the_lab.md #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

marcobarilari
Copy link
Contributor

@marcobarilari marcobarilari commented Sep 19, 2024

This is a mock pr with just some text filler

Summary by Sourcery

Add initial content to the 'buying_things_for_the_lab.md' documentation file with placeholder text.

Documentation:

  • Add initial content to 'buying_things_for_the_lab.md' with placeholder text.

Copy link
Contributor

sourcery-ai bot commented Sep 19, 2024

Reviewer's Guide by Sourcery

This pull request adds a new markdown file 'buying_things_for_the_lab.md' with placeholder content. The file includes a main heading, a subheading, and two paragraphs of Lorem Ipsum text.

File-Level Changes

Change Details Files
Added a new markdown file with placeholder content
  • Created a main heading
  • Added a subheading
  • Included two paragraphs of Lorem Ipsum text
doc/buying_things_for_the_lab.md

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcobarilari - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The content of the file doesn't match its filename. If this is intended to be a placeholder, please clearly indicate so and consider using a skeleton structure relevant to 'buying things for the lab' instead of lorem ipsum text.
  • The markdown formatting could be improved. Consider removing unnecessary blank lines and ensuring consistent use of header levels.
  • If this file is meant to provide guidelines for purchasing lab equipment, consider creating a basic structure with empty sections instead of using placeholder text. This would be more useful for future development.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Comment on lines 1 to 8
# Lorem ipsum dolor

## sit amet, consectetur adipiscing elit. Sed vestibulum semper felis quis accumsan.


Ut consequat augue quis dui sagittis, eget molestie odio vehicula. Vestibulum volutpat tristique ante vitae convallis.

Integer condimentum nunc condimentum egestas tristique. Nulla facilisi. Duis pulvinar volutpat diam, a aliquam nibh feugiat lobortis. Mauris pretium mollis elit vel venenatis. Fusce tincidunt lorem id lectus tempor vulputate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (documentation): The content appears to be placeholder text (Lorem ipsum) rather than actual documentation.

Please replace this with the intended content about buying things for the lab. If this is intentionally left as a placeholder, consider adding a TODO comment to indicate that it needs to be filled in later.

Copy link
Contributor

@fcerpe fcerpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check languages

Co-authored-by: Filippo Cerpelloni <filippo.cerpelloni@gmail.com>
@marcobarilari marcobarilari merged commit 406ac47 into main Sep 19, 2024
1 check passed
@marcobarilari marcobarilari deleted the marcobarilari_edit_buying_things branch September 19, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants