-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements using directives, using declarations and namespace aliases #545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI aside, LGTM. It would be good if we were already using it in the handlebars templates.
@sdkrystian Couldn't a .inc
file (like the ones LLVM generates) defining these Info types maybe be useful here? I lot of code going through these types defining things is looking very repetitive. (It would be a simple list of macro calls for each info name so we don'tt need a .td
file of course.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add support for these new Info
kinds to the adoc templates, and this should be good to go.
@sdkrystian Or do you mean something else? |
The XML schema needs to be updated. With respect to updating the asciidoc templates, you need to add handlebars partials for rendering the documentation page of an |
@fpelliccioni Please try generating an asciidoc reference containing using declarations/using directives/namespace aliases. The asciidoc partials you wrote contain numerous errors, so it would be easier if you were able to see the output and adjust them accordingly :) |
share/mrdocs/addons/generator/asciidoc/partials/signature/alias.adoc.hbs
Outdated
Show resolved
Hide resolved
share/mrdocs/addons/generator/asciidoc/partials/signature/alias.adoc.hbs
Outdated
Show resolved
Hide resolved
share/mrdocs/addons/generator/asciidoc/partials/signature/alias.adoc.hbs
Outdated
Show resolved
Hide resolved
share/mrdocs/addons/generator/asciidoc/partials/signature/alias.adoc.hbs
Outdated
Show resolved
Hide resolved
share/mrdocs/addons/generator/asciidoc/partials/signature/using.adoc.hbs
Outdated
Show resolved
Hide resolved
share/mrdocs/addons/generator/asciidoc/partials/signature/using.adoc.hbs
Outdated
Show resolved
Hide resolved
share/mrdocs/addons/generator/asciidoc/partials/signature/using.adoc.hbs
Outdated
Show resolved
Hide resolved
share/mrdocs/addons/generator/asciidoc/partials/signature/using.adoc.hbs
Outdated
Show resolved
Hide resolved
Why has this been sitting in the PR queue for 5+ weeks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure tests pass in CI, otherwise LGTM
The PR is quite comprehensive, touching on 63 files across different parts of the project. It took some time to ensure everything was aligned and functioning as expected. The good news is that the PR has now passed all CI checks and has been approved. I'm merging it as we speak. Really appreciate your patience and support! |
@sdkrystian I am not abled to merge it. |
0ce2623
to
0086ab6
Compare
This has been merged even though it broke CI https://github.com/cppalliance/mrdocs/actions/runs/8819808424 See develop runs in: https://github.com/cppalliance/mrdocs/actions?query=branch%3Adevelop |
I will take a look at it
…On Sat, May 11, 2024, 5:39 AM Alan de Freitas ***@***.***> wrote:
This has been merged even though it broke CI
https://github.com/cppalliance/mrdocs/actions/runs/8819808424
—
Reply to this email directly, view it on GitHub
<#545 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACC2EYITLZSC53HKDRQTLDZBWHGTAVCNFSM6AAAAABEPJIICKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGUYTQMJWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.