Ci repair #1763
Merged
Ci repair #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thetic
commented
Oct 28, 2023
thetic
commented
- Remove gtest builds. They depend on Python 2 which is no longer available in GitHub actions.
- Suppress ClangCL warning for "unsafe buffer usage" that flags all the raw string operations.
offa
approved these changes
Oct 30, 2023
|
Thanks for still paying attention after my lack of attention the last months. Is there no better solution than this? |
|
Maybe, but I'd like to get CI passing in the meantime. I don't have much interest in trying to resurrect Python 2, and I would expect any workaround to be pretty involved and/or fragile. |
|
can someone merge it please? would love to see a new build in releases section! |
|
Ok.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.