Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

debug_backtrace() output reveals implementation details? #16

Closed
cpriest opened this Issue · 5 comments

2 participants

@cpriest
Owner

Same as #14, what does current output look like and what do we want it to look like.

@nikic
Collaborator

Instead of function => __getfoo I'd use property => foo and accessor => get in the debug backtrace. Do those names sound good to you?

@nikic
Collaborator

One complication that I see with this is that it would use the new format always, not just when called via a property. But as the internal functions aren't supposed to be directly called anyway that shouldn't matter, should it?

@cpriest
Owner

When you say the internal implementations, do you mean auto-implemented __getFoo()? Are you saying that an auto-implemented __getFoo() would not be callable directly or be listed as a method of the class?

I think that's no good...

@nikic
Collaborator

Now the backtrace includes "function" => "$foo->get". I guess that's better for users as they don't need to specifically distinguish between function and property in their use. One might add something like property+accessor additionally though.

@cpriest
Owner

Yeah, I think this is just fine.

@cpriest cpriest closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.