-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For 150: updated list of implemented metrics #433
Conversation
This pull request #433 is assigned to @Vatavuk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulodamaso one comment
@@ -110,7 +110,7 @@ _Revisiting Class Cohesion: An empirical investigation on several systems_,<br/> | |||
Journal of Object Technology, vol.7, no.6, 2008, | |||
[PDF](http://www.jot.fm/issues/issue_2008_07/article1.pdf). | |||
|
|||
Here is a list of metrics we already implement: | |||
###Here is a list of metrics we already implement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulodamaso I believe grammar is incorrect, Here is a list of metrics that we've already implemented
@Vatavuk @paulodamaso I didn't see you took care of this, but I got the task assigned earlier and tackled it, see #435. I believe it's more complete that this one. |
@paulodamaso ping |
@sereshqua/z please review this job completed by @Vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@Vatavuk please make sure you will find at least 3 issues during next CT @paulodamaso please make sure all issues found by code reviewers would be fixed by you if you were pull-request author again I've seen that this is no longer actual, but policy is policy |
@sereshqua Will do, thanks |
@sereshqua ok |
@0crat quality acceptable |
For !50: