Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For 150: updated list of implemented metrics #433

Closed
wants to merge 1 commit into from

Conversation

paulodamaso
Copy link
Collaborator

For !50:

  • updated the list of implemented metrics

@0crat
Copy link
Collaborator

0crat commented Mar 29, 2020

This pull request #433 is assigned to @Vatavuk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

Copy link

@Vatavuk Vatavuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso one comment

@@ -110,7 +110,7 @@ _Revisiting Class Cohesion: An empirical investigation on several systems_,<br/>
Journal of Object Technology, vol.7, no.6, 2008,
[PDF](http://www.jot.fm/issues/issue_2008_07/article1.pdf).

Here is a list of metrics we already implement:
###Here is a list of metrics we already implement:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso I believe grammar is incorrect, Here is a list of metrics that we've already implemented

@victornoel
Copy link
Contributor

@Vatavuk @paulodamaso I didn't see you took care of this, but I got the task assigned earlier and tackled it, see #435. I believe it's more complete that this one.

@Vatavuk
Copy link

Vatavuk commented Mar 31, 2020

@paulodamaso ping

@paulodamaso paulodamaso closed this Apr 1, 2020
@0crat 0crat removed the scope label Apr 1, 2020
@0crat
Copy link
Collaborator

0crat commented Apr 1, 2020

@sereshqua/z please review this job completed by @Vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Apr 1, 2020

Pull request #433 was not merged, no payment for ARC, see §28

@sereshqua
Copy link

@Vatavuk please make sure you will find at least 3 issues during next CT

@paulodamaso please make sure all issues found by code reviewers would be fixed by you if you were pull-request author again

I've seen that this is no longer actual, but policy is policy

@paulodamaso
Copy link
Collaborator Author

@sereshqua Will do, thanks

@Vatavuk
Copy link

Vatavuk commented Apr 2, 2020

@sereshqua ok

@sereshqua
Copy link

@0crat quality acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants