Fix PDF printing in Firefox version >= 110 #657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getFirefoxMajorVersion
function to theBrowser
module (another alternative would be to use sniffr, but thought not to add an extra dependency)Print
module only for Firefox major versions < 110Testing
Tested the changes using
test/manual/index.html
on a Linux machine with Firefox 110.0 and Chrome 109.0.5414.74