Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDF printing in Firefox version >= 110 #657

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

amoilanen
Copy link
Contributor

@amoilanen amoilanen commented Feb 20, 2023

Changes

  • Add getFirefoxMajorVersion function to the Browser module (another alternative would be to use sniffr, but thought not to add an extra dependency)
  • Apply the Firefox-specific workarounds in the Print module only for Firefox major versions < 110

Testing

Tested the changes using test/manual/index.html on a Linux machine with Firefox 110.0 and Chrome 109.0.5414.74

@amoilanen amoilanen changed the title Fix printing in Firefox version >= 110 Fix PDF printing in Firefox version >= 110 Feb 20, 2023
@LukasKlement
Copy link

This fix is critical to support the latest version of Firefox. Without this PR, the library looses most of its raison d'être. Please merge and release a new version asap 🙏

@ZakiMohammed
Copy link

@crabbly Please review and once approved, please merge this PR asap 🙏

@crabbly crabbly merged commit 1d7eb77 into crabbly:master Feb 25, 2023
@ZakiMohammed
Copy link

@crabbly please help me understand, when we are expecting these changes in next release? What will be the date of next release?

@Gildedter
Copy link

Waiting for the release, I was wondering why it broke, was it cause by updating my Firefox?

@LukasKlement
Copy link

@Gildedter yes, it is a change in Firefox v110, which is now working more similar to other browser engines (Webkit + Blink). All in all, a good thing. Thanks @amoilanen for the PR and @crabbly for merging it. @crabbly could you please release a new version on npmjs 🙏 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants