Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update msrv to v1.73 #49

Merged
merged 1 commit into from
Feb 9, 2024
Merged

chore(deps): update msrv to v1.73 #49

merged 1 commit into from
Feb 9, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 5, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change Pending
rust minor 1.69.0 -> 1.73 1.76 (+2)
rust minor 1.69 -> 1.73 1.76 (+2)

Release Notes

rust-lang/rust (rust)

v1.73

Compare Source

==========================

Language

Compiler

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Misc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

v1.72

Compare Source

===========================

v1.71

Compare Source

===========================

v1.70

Compare Source

==========================

Language

Compiler

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

Cargo

Misc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.


Configuration

📅 Schedule: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@alerque
Copy link

alerque commented Oct 6, 2023

Why? Bumping the MSRV is a breaking change and shouldn't be done if the project doesn't actually need it, and if it does it should be marked as breaking. Just bumping because you can is a terrible idea.

@epage
Copy link
Contributor

epage commented Oct 6, 2023

Bumping MSRV is not generally recognized as a breaking change. It is subset of "build environment requirements". If those were considered breaking changes, then every time rustc demotes a target between tiers, requires new glibc, etc, rustc would need to bump its major version.

As for proactively bumping MSRV,

  • It gives permission for contributors to projects to use new features. A lot of times contributors are cautious, taking the most conservative route possible, even if it makes the contribution worse. Giving them more explicit permission improves their experience
  • This ensures people are aware of the MSRV policy and don't assume the policy is anything different. Too often I've seen people assume an MSRV policy based on the current MSRV and get frustrated when their expectations are not met
  • Lower maintenance overhead

Rarely have I seen someone have a fixed MSRV policy that can generally work for people (Debian being one of the main ones). Instead other open source projects tend to have a sliding MSRV window, like 3 releases or 6 months, so making my MSRV policy variable does not help any of them.

@renovate renovate bot changed the title chore(deps): update msrv to v1.70 chore(deps): update msrv to v1.72 Jan 24, 2024
@renovate renovate bot changed the title chore(deps): update msrv to v1.72 chore(deps): update msrv to v1.73 Feb 9, 2024
@epage epage merged commit ee8bf86 into master Feb 9, 2024
16 checks passed
@epage epage deleted the renovate/rust-1.x branch February 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants