Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Improve detection of ignorable cases #486

Merged
merged 6 commits into from
May 10, 2022
Merged

fix(parser): Improve detection of ignorable cases #486

merged 6 commits into from
May 10, 2022

Conversation

epage
Copy link
Collaborator

@epage epage commented May 10, 2022

epage added 6 commits May 10, 2022 12:58
@epage
refactor(parser): Clarify precedence levels
ad89736
@epage
test(parser): Remove unclear test case
4869764 
Unsure why this case is here and it causes difficulties
@epage
test(parser): Add reproduction of crate-ci#481
7e15afe
@epage
fix(parser): Ignore items at end of input
1720e7d
@epage
fix(parser): Allow backslashes after ignore items
bd5048d 
To allow `\\` to start a token, we couldn't let it end a token.  By
switching the termiantor to a peek, we can now make it end a token
**and** start a token, allowing us to work better with windows paths.

Fixes crate-ci#481
@epage
fix(parser): Better short base64 detection
fd53983 
Previously, we bailed out if the string is too short (<90) and there
weren't non-alpha-base64 bytes present.  What we ignored were the
padding bytes.

We key off of padding bytes to detect that a string is in fact base64
encoded.  Like the other cases, there can be false positives but those
strings should show up elsewhere or the compiler will fail.

This was called out in crate-ci#485
@epage epage mentioned this pull request May 10, 2022
Closed
@epage epage merged commit 5e7e699 into crate-ci:master May 10, 2022
@epage epage deleted the change branch May 10, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@epage