Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Improve detection of ignorable cases #486

Merged
merged 6 commits into from
May 10, 2022
Merged

fix(parser): Improve detection of ignorable cases #486

merged 6 commits into from
May 10, 2022

Commits on May 10, 2022

  1. refactor(parser): Clarify precedence levels

    @epage
    epage committed May 10, 2022
    Configuration menu
    Copy the full SHA
    ad89736 View commit details
    Browse the repository at this point in the history

  2. test(parser): Remove unclear test case 

    Unsure why this case is here and it causes difficulties
    @epage
    epage committed May 10, 2022
    Configuration menu
    Copy the full SHA
    4869764 View commit details
    Browse the repository at this point in the history

  3. test(parser): Add reproduction of crate-ci#481

    @epage
    epage committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7e15afe View commit details
    Browse the repository at this point in the history

  4. fix(parser): Ignore items at end of input

    @epage
    epage committed May 10, 2022
    Configuration menu
    Copy the full SHA
    1720e7d View commit details
    Browse the repository at this point in the history

  5. fix(parser): Allow backslashes after ignore items 

    To allow `\\` to start a token, we couldn't let it end a token.  By
switching the termiantor to a peek, we can now make it end a token
**and** start a token, allowing us to work better with windows paths.

Fixes crate-ci#481
    @epage
    epage committed May 10, 2022
    Configuration menu
    Copy the full SHA
    bd5048d View commit details
    Browse the repository at this point in the history

  6. fix(parser): Better short base64 detection 

    Previously, we bailed out if the string is too short (<90) and there
weren't non-alpha-base64 bytes present.  What we ignored were the
padding bytes.

We key off of padding bytes to detect that a string is in fact base64
encoded.  Like the other cases, there can be false positives but those
strings should show up elsewhere or the compiler will fail.

This was called out in crate-ci#485
    @epage
    epage committed May 10, 2022
    Configuration menu
    Copy the full SHA
    fd53983 View commit details
    Browse the repository at this point in the history