Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for ... #380

Closed
amotl opened this issue Apr 18, 2023 · 1 comment
Closed

Add test case for ... #380

amotl opened this issue Apr 18, 2023 · 1 comment

Comments

@amotl
Copy link
Member

amotl commented Apr 18, 2023 •
edited
Loading

Maybe it makes sense to add a test case for GH-378 / GH-379, corresponding to crate/pgjdbc#38?

Changed getPrimaryKeys() SQL stmt to use the table schema as the schema instead of the table catalog. This fixes compatibility with CrateDB >= 5.1.0 as all catalog fields at the information_schema.tables schema expose now the correct catalog value (crate) instead of the table schema.

/cc @seut
@seut
Copy link
Member

seut commented Apr 19, 2023

@amotl Thanks for mentioning.
This is already covered by MetaDataITest.testGetPrimaryKeysPk() which fails without the corresponding patches on CrateDB >= 5.1.0. I've just now verified this.

@seut seut closed this as completed Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seut @amotl