Fix object array type test. #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovrus
force-pushed
the
r/object-array
branch
from
06d7199
to
c8942de
Compare
CrateDB >= 4.1.0 maps the `array(object)` data type to the `PGArray(JSON)` instead of `JSON` Postgres type. Therefore, the test case has to be adjusted. See crate/crate@8e1ba66
kovrus
force-pushed
the
r/object-array
branch
from
c8942de
to
e20434c
Compare
mfussenegger
approved these changes
Nov 29, 2019
kovrus
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
CrateDB >= 4.1.0 maps the
array(object)data type tothe
PGArray(JSON)instead ofJSONPostgres type.Therefore, the test case has to be adjusted.
See crate/crate@8e1ba66
Checklist