Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goldified Spellbooks #485

Closed
wants to merge 20 commits into from
Closed

Goldified Spellbooks #485

wants to merge 20 commits into from

Conversation

Doesnty
Copy link
Contributor

@Doesnty Doesnty commented Mar 3, 2017

This set of commits changes spellbooks to function like gold, runes and the orb. Instead of sitting in inventory, picking up a book causes it to cease to exist and add spells to the player's library, which they can memorize from at any time.

-Learnable spells in the book are listed upon picking it up.
-Books with no usable or new spells are tagged useless. This was meant to make shopping painless, but had the consequence of making book acquirement much different; it will consistently not give useless books but is more prone to empty acquirements. To counter this, I added code to make it attempt to give a manual if it would give a useless spellbook.
-Trog loses book burning and gains absolutely nothing in return.
-Sif Muna is not directly changed. They should probably beam spells straight to the library instead of dropping books at your feet now. Book gifts run off of acquirement and thus are more useful. Sif also stops giving books once the player has every spell instead of drowning them in a torrent of redundant books.
-Vehumet is completely unchanged. Offered gifts are not added to the library and are withdrawn as normal.
-Background descriptions could use touching up as the player doesn't see their starting book anymore.
-On loading an old save, all books in the player's inventory have their contents added to the library and then disintegrate.

@yrmvgh
Copy link
Contributor

yrmvgh commented Mar 3, 2017

Impressive! I'll pull this into my fork and let you know if I notice any problems. Thanks for doing this!

@yrmvgh
Copy link
Contributor

yrmvgh commented Mar 16, 2017

I tried this in yiufcrawl and it's working without problems so far! Here's a screenshot of an existing character from a previous version converting a pile of books from the floor to the library:
http://i.imgur.com/wMMVj7L.png

Do you have any plans for maybe a sort/filter feature in the player library?

@isloat
Copy link
Contributor

isloat commented Apr 3, 2017

Do you have any further changes or fixes you'd like to make to this? There was some discussion a couple weeks ago on c-r-d and in ##-dev about this. We're generally favorable, but there's a couple things that need to be ironed out first.

  1. Trog. Have him burn spellbooks on sight if you're following the god. Retain book-burning behavior for that one Trog vault.
  2. Spell list sorting. With a large library of spells the memorisable spell list becomes very unwieldly. Additional sorting options would significantly help this. It would be great to have a toggle between book sort, spell school sort, and spell level sort.

@semitonal
Copy link
Member

semitonal commented Apr 3, 2017

Book burning on-sight doesn't work, as has been previously discussed - there are many identifiable vaults with books that are guaranteed, or with high chances of books. The only way that'd function as a conduct is to burn all books on generation or on abandonment, and I don't think that's a very interesting conduct.

@Doesnty
Copy link
Contributor Author

Doesnty commented Jul 13, 2017

i'm apparently persona non grata now so someone else gets to finish this i guess

bye

@Doesnty Doesnty closed this Jul 13, 2017
@wheals wheals mentioned this pull request Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants