remotingfrontend/virtgpu: give more time to load the libraries and log a warning on failure #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a warning on failure
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Caution Review failedThe pull request is closed. WalkthroughThe changes increase the maximum wait time for a remote call response in the virtual GPU frontend and add a warning log message when a timeout occurs in the remote call function. No changes were made to public interfaces or exported declarations. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @kpouget - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `ggml/src/ggml-remotingfrontend/virtgpu.cpp:497` </location>
<code_context>
os_time_sleep(base_sleep_us);
total_us += base_sleep_us;
if (max_us && total_us > max_us) {
+ WARNING("%s: timed out waiting for the API remoting answer...", __func__);
return NULL;
}
</code_context>
<issue_to_address>
Consider including more context in the timeout warning.
Including the total wait time or relevant parameters in the warning would make it more useful for debugging and monitoring.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
WARNING("%s: timed out waiting for the API remoting answer...", __func__);
=======
WARNING("%s: timed out waiting for the API remoting answer after %" PRIu64 " us (max_us=%" PRIu64 ")", __func__, total_us, max_us);
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| os_time_sleep(base_sleep_us); | ||
| total_us += base_sleep_us; | ||
| if (max_us && total_us > max_us) { | ||
| WARNING("%s: timed out waiting for the API remoting answer...", __func__); |
There was a problem hiding this comment.
suggestion: Consider including more context in the timeout warning.
Including the total wait time or relevant parameters in the warning would make it more useful for debugging and monitoring.
Suggested change
| WARNING("%s: timed out waiting for the API remoting answer...", __func__); | |
| WARNING("%s: timed out waiting for the API remoting answer after %" PRIu64 " us (max_us=%" PRIu64 ")", __func__, total_us, max_us); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Summary by Sourcery
Give the virtgpu remoting frontend more time to initialize API libraries and emit a warning on timeout rather than triggering a fatal error.
Enhancements:
Summary by CodeRabbit