fix for empty default value

[wweir]

No description provided.

[codecov]

Codecov Report

Merging #66 (3deab44) into main (32a7c36) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   92.22%   92.24%   +0.02%     
==========================================
  Files           3        3              
  Lines         360      361       +1     
==========================================
+ Hits          332      333       +1     
  Misses         23       23              
  Partials        5        5              

Impacted Files	Coverage Δ
aconfig.go	92.37% <100.00%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a7c36...3deab44. Read the comment docs.

[wweir]

The field AllFieldRequired will not work in the example code

	type MyConfig struct {
		Port int `usage:"just give a number"`
		Auth struct {
			User string `default:"def-user"`
			Pass string `default:"def-pass"`
		}
		Pass string `flag:"sec_ret" required:"true"`
	}

	var cfg MyConfig
	loader := aconfig.LoaderFor(&cfg, aconfig.Config{
		AllFieldRequired: true,
		// SkipDefaults:     true,
	})

	if err := loader.Load(); err != nil {
		panic(err)
	}

	log.Println(cfg)

[cristaloleg]

Hi, I don't get what you're expecting. Is this related to this line? https://github.com/cristalhq/aconfig/blob/main/aconfig.go#L48

[wweir]

@cristaloleg Yes, the option AllFieldRequired and the tag required dose not work correctly.
It will be initialized by the empty default value.

[wweir]

The code in PR is not the best way to fix it.

[cristaloleg]

I don't mean it's incorrect, I'm asking is this related to the AllFieldRequired documented behaviour ?

[wweir]

Yes, I have already answered.
The flag AllFieldRequired does not work correctly if SkipDefaults is false.

Have you do any testing on the behavior of AllFieldRequired ?

[cristaloleg]

Now it's better, you haven't mentioned SkipDefaults before.

[cristaloleg]

lgtm

[cristaloleg]

Thanks 🎉