Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection calculation is slightly off #47

Closed
crkellen opened this issue May 2, 2017 · 1 comment
Closed

Selection calculation is slightly off #47

crkellen opened this issue May 2, 2017 · 1 comment
Assignees
@crkellen
Labels
bug non-critical
Projects
Alpha v0.5.0
Milestone
v0.4.5 --- Fix ma...

Comments

@crkellen
Copy link
Owner

crkellen commented May 2, 2017

The calculation for selGridX/Y is not exactly 80. It is sometimes off by a small amount. ~10 pixels or so.
@crkellen crkellen self-assigned this May 2, 2017
@crkellen crkellen added this to Bugs in Alpha v0.5.0 May 2, 2017
@crkellen crkellen moved this from Bugs to Ready for Implementation in Alpha v0.5.0 May 2, 2017
crkellen pushed a commit that referenced this issue May 3, 2017
v0.4.3 - Bugfixes
428e79d 
Check changelog for current changes. Still need to get rid of #46 and #47 before I say v0.4.5 is done. Going to look into #20 and #29 as well for v0.4.5.
@crkellen crkellen moved this from Ready for Implementation to In Progress in Alpha v0.5.0 May 11, 2017
@crkellen crkellen moved this from In Progress to Ready for Implementation in Alpha v0.5.0 May 16, 2017
@crkellen crkellen moved this from Ready for Implementation to In Progress in Alpha v0.5.0 May 17, 2017
@crkellen
Copy link
Owner Author

This was due to using the localPlayer's mX and mY which would be sent after/outdated by the time of selection calculation. This has been solved. Working on implementing a better selection highlight now.

@crkellen crkellen moved this from In Progress to Completed in Alpha v0.5.0 May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crkellen crkellen

Labels
bug non-critical
Projects
Alpha v0.5.0
Completed
Milestone
v0.4.5 --- Fix major issues/bugs from...
Development

No branches or pull requests
1 participant
@crkellen