This repository has been archived by the owner on Feb 11, 2025. It is now read-only.
WIP - Catch signals while running terraform commands to allow clean termination #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
Signed-off-by: Bob Haddleton <bob.haddleton@nokia.com>
|
This PR has been moved to the new repository: upbound/provider-terraform#231 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add signal handling when calling terraform commands that lock state so that the command can be gracefully terminated to clean up the workspace state locking.
Fixes #46
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Created a Workspace that has a terraform time_sleep resource with create_timeout set to 5 minutes and uses the terraform kubernetes backend
While tailing the pod log apply the workspace and observe that the reconcile of the workspace starts
Retrieve the list of kubernetes lease resources and observe that there is a lease for the specified workspace
Terminate the provider pod and observe in the logs that the process gets terminated. Observe that the Lease for the workspace has been deleted.