initial contribution #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
maximilianbraun
force-pushed
the
contribution-sap
branch
5 times, most recently
from
7a85c86
to
38705ac
Compare
Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Mirza Kopic <mirza.kopic@sap.com> Co-authored-by: Stephan Discher <stephan.discher@sap.com> Co-authored-by: Johannes Ott <johannes.ott@sap.com> Co-authored-by: Denis Holschuh <d.holschuh@sap.com> Signed-off-by: Maximilian Braun <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
maximilianbraun
force-pushed
the
contribution-sap
branch
from
38705ac
to
59bd55e
Compare
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
haarchri
reviewed
Oct 31, 2023
|
LGTM! (minus the readme conflict) I was able to point the e2e PR from provider-cortex to this branch and it ran without issues. Thanks a lot @maximilianbraun! |
Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
maximilianbraun
added a commit
that referenced
this pull request
Oct 31, 2023
initial contribution Co-authored-by: Christian Volk <christian.volk@sap.com> Co-authored-by: Mirza Kopic <mirza.kopic@sap.com> Co-authored-by: Stephan Discher <stephan.discher@sap.com> Co-authored-by: Johannes Ott <johannes.ott@sap.com> Co-authored-by: Denis Holschuh <d.holschuh@sap.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from https://github.com/maximilianbraun/xp-testing/tree/main & adjusted references