Pushing encoder changes to support the encoder version RGB #176
Conversation
… into encoder-changes-rgb8 cr https://code.amazon.com/reviews/CR-10812271
|
Please review this change, but can you please hold off on the approval till I can get back to you about it? |
|
Yes, the change looks pretty good; we can pull this change into our internal repo so it will be included in the next update to the open source version. What other changes are you planning? |
|
As of now, I do not have anything else. Could you please hold off on the approval and merging though? Also, may I know when the next update to the open source version will be? |
|
Ok, but are you planning to test more or make changes, or what are we waiting for? We don't have an exact schedule for updates, we can do it anytime. For example, the last update #174 also included some more image encodings. |
|
It looks like there won't be any further changes at this time, @jtbandes. Thank you for holding off on the request. You can go ahead and merge these changes into the main branch of source code. |
|
Hello @jtbandes , could you tell me when these updates to the source code will be available in the main stream? |
Changelog: - Added Note panel. - Added Polygon drawing tools to 3D panel. - Image panel now supports rgb8 encoding (thanks @pvnkot! closes #176) - Improved the default layout when visiting Webviz for the first time. - Various bug fixes to bag streaming support. - Fixed an issue where the Plot panel axes would change when pressing play.
Changelog: - Added Note panel. - Added Polygon drawing tools to 3D panel. - Image panel now supports rgb8 encoding (thanks @pvnkot! closes #176) - Improved the default layout when visiting Webviz for the first time. - Various bug fixes to bag streaming support. - Fixed an issue where the Plot panel axes would change when pressing play.
|
Done in #178 |
Summary
This change is being requested to support Image View for ROS bag files that have been recorded with RGB Image encoding. BGR is already supported, but this change adds support for RGB images too.
Test plan
This change was tested by loading the /camera/rgb/image_raw view with a ROS Bag file that was recorded with RGB encoding format. The Camera image and video feed load and work fine.
Versioning impact
Requires a patched version.