-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: background scripts for firefox build #790
fix: background scripts for firefox build #790
Conversation
🦋 Changeset detectedLatest commit: 56abaad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@jacksteamdev can you add the request to npm version? |
Hi @SaltyCucumber , can this PR by any chance fix #801 ? And have you experienced this problem with Firefox at all? |
Are you trying to use a dev build with HMR? |
@jacksteamdev This PR fixes some issues in #776 where the background script was being completely ignored on build. Can we merge and deploy it asap so that we can benefit from the newly introduced Firefox support? |
@SaltyCucumber @Stevenkhalife I've done a code review but haven't had time to test this live. If there are any bugs, it's up to the community to make a PR. Thanks for the contributions! |
This is a follow up to #776
I tried it out and the firefox build ignores background scripts, this PR fixes it