-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor fixes #221
minor fixes #221
Conversation
@@ -11,6 +11,10 @@ def __init__(self, name, alias, device_type, keys, fullpath, manager): | |||
self.fullpath = fullpath | |||
self.manager = manager | |||
|
|||
def create_psbts(self, base64_psbt, wallet): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works :) But maybe if no method is available, we should show the PSBT/ a button to copy it and tell the user to use the paste transaction button to do the signing? Right now it just brings a popup with no options. You can just take the copy PSBT functionality from the Raw PSBT section in the transaction details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the next thing I was thinking about. I thought about adding a "Generic wallet" option that would include QR code with base64 psbt, copy-text and download file - all with the same base64 psbt. Especially taking into account that "Other" option is not available anymore in the import device screen - we show an error there if the device type is not selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds even better :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I tested most/ all cases, works great :) I guess the Generic device can be either here or in its own PR if you want to keep this to bug fixes.
Oh, just 2 suggestions for changes which feel too small for another PR:
|
Working on it already :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Fixes:
process_psbt
function