added fix for elliptic recovery bug

cryptocoinjs · Jan 18, 2016 · 58b9e7b · 58b9e7b
1 parent fe8a988
commit 58b9e7b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lib/elliptic/recover.js b/lib/elliptic/recover.js
@@ -28,6 +28,10 @@ exports.recoverSync = function (msg, signature, recovery) {
   try {
     var sigObj = {r: signature.slice(0, 32), s: signature.slice(32, 64)}
     var pubKey = ec.recoverPubKey(msg, sigObj, recovery)
+    if (!ec.verify(msg, sigObj, pubKey)) {
+      throw new Error(messages.ECDSA_RECOVER_FAIL)
+    }
+
     return new Buffer(pubKey.encodeCompressed())
   } catch (err) {
     throw new Error(messages.ECDSA_RECOVER_FAIL)