Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libotr 4.1.x support #50

Closed
ysangkok opened this issue Jan 12, 2015 · 6 comments
Closed

libotr 4.1.x support #50

ysangkok opened this issue Jan 12, 2015 · 6 comments

Comments

@ysangkok
Copy link

The readme says that irssi-otr needs libotr 4.0.x. This is not the latest version and it is an inconvenience.

@andreasstieger
Copy link
Contributor

Works fine with libotr 4.1.0, there is no special support required. Do you have a specific issue with this version?

@ysangkok
Copy link
Author

I just tried building with the new version, and it seems to work. But I'm uncomfortable disobeying the instructions.

@dgoulet
Copy link
Member

dgoulet commented Jan 12, 2015

I just updated the README that contained some old info.

Thanks for the report!

On 12 Jan (11:19:19), Janus Troelsen wrote:

I just tried building with the new version, and it seems to work. But I'm uncomfortable disobeying the instructions.


Reply to this email directly or view it on GitHub:
#50 (comment)

@andreasstieger
Copy link
Contributor

I think the more strict 4.1.x in 4ad3b7b is wrong or at least incomplete. libotr >= 4.0.0 is sufficient and matches configure.ac?

@dgoulet
Copy link
Member

dgoulet commented Jan 12, 2015

On 12 Jan (11:41:06), Andreas Stieger wrote:

I think the more strict 4.1.x in 4ad3b7b is wrong or at least incomplete. libotr >= 4.0.0 is sufficient and matches configure.ac?

4.1.0 has a critical fix for irssi-otr which before distros had to pull
it manually in their package.

So, I would really advocate for 4.1.x here because of that.


Reply to this email directly or view it on GitHub:
#50 (comment)

@andreasstieger
Copy link
Contributor

As a distribution package maintainer I am aware of that, but would recommend the above for completeness.

dgoulet pushed a commit that referenced this issue Mar 25, 2016
Follow-up to 4ad3b7b and issue #50 - specify
minimm requirement of libotr >= 4.1.0 in configure.ac and spec file.

Fixes #51

Signed-off-by: David Goulet <dgoulet@ev0ke.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants