Compiler: don't skip all yield nodes if one is missing an exp type #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems when some yield expression didn't have a type we would break out from the yield typing logic. It makes sense to skip that yield but not all yields. This essentially changes a `return` for a `next` in a nested loop, but because the logic was getting a bit large and confusing a method was extracted for the contents of one loop.
asterite
added
kind:bug
jhass
approved these changes
Aug 21, 2019
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
…rystal-lang#8101) It seems when some yield expression didn't have a type we would break out from the yield typing logic. It makes sense to skip that yield but not all yields. This essentially changes a `return` for a `next` in a nested loop, but because the logic was getting a bit large and confusing a method was extracted for the contents of one loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8100
It seems when some yield expression didn't have a type we would break out from the yield typing logic. It makes sense to skip that yield but not all yields. This essentially changes a
returnfor anextin a nested loop, but because the logic was getting a bit large and confusing a method was extracted for the contents of one loop.