Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PartialComparable #8596

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Remove PartialComparable #8596

merged 2 commits into from
Dec 19, 2019

Conversation

Blacksmoke16
Copy link
Member

Module was deprecated 4 minor versions ago as part of #7664, probably is safe to remove now.

bcardiff
bcardiff approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a cleanup branch removing many deprecated methods. This was one of them. So 👍

@bcardiff bcardiff merged commit f9a4d18 into crystal-lang:master Dec 19, 2019
@bcardiff bcardiff added this to the 0.33.0 milestone Dec 19, 2019
@Blacksmoke16 Blacksmoke16 deleted the remove-partial-compare branch December 19, 2019 14:03
@RX14
Copy link
Contributor

RX14 commented Dec 21, 2019 •
edited
Loading

👍 for the cleanup branch getting a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
breaking-change kind:feature topic:stdlib:collection
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Blacksmoke16 @RX14 @bcardiff @straight-shoota