Initial implementation of the new OpenInApp API #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
openinapp
branch
4 times, most recently
from
4e2cd9d
to
fb418ac
Compare
glpatcern
changed the title
glpatcern
force-pushed
the
openinapp
branch
3 times, most recently
from
0f7ec3a
to
86d7e16
Compare
|
@glpatcern can you update go.mod to the latest cs3apis version? |
|
#1719 merged |
|
All right, rebasing plus one more "linting" made it. This is ready for merge. |
labkode
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new
OpenInAppAPI by moving the code previously created forOpenFileInAppProvider. The latter is deprecated.For the time being, the implementation lacks the apps registry, where the
appparameter would be used as key to get the returned URL. Instead, theappis just prepended to the returned URL. Of course, the current behavior is preserved, i.e. if noappis provided, the app URL is worked out from the (WOPI) registry.TODO in a later PR: