Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix moving of a shared file between shares #2026

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Sep 1, 2021

As the share receiver, moving a shared file to another share was not possible.

@phil-davis
Copy link
Contributor

Related issue owncloud/ocis#2442

phil-davis
phil-davis previously approved these changes Sep 1, 2021
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - fixes issue owncloud/ocis#2442 and various test scenarios that depend on that issue.

Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkode correct me if I am wrong. The storageprovider is not supposed to deal with cross storageprovider move requests, right? Cross storage moves are a COPY and DELETE operation that will create a new resource with a new fileid. A cross storage move needs to be handled by the client, so that it can notify the user about the change.

That being said, we are planning to be able to move spaces between storage providers if they a able to import ids, which depends on the implementation.

@C0rby can you fix this in the ocdav layer instead of the CS3 gateway?

@C0rby C0rby self-assigned this Sep 3, 2021
@C0rby C0rby changed the title fix moving of a shared file between share fix moving of a shared file between shares Sep 3, 2021
@labkode labkode merged commit bd4575a into cs3org:master Sep 8, 2021
@C0rby C0rby deleted the fix-move-of-shared-file branch September 8, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants