-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix moving of a shared file between shares #2026
Conversation
eeb5d93
to
8298f37
Compare
Related issue owncloud/ocis#2442 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - fixes issue owncloud/ocis#2442 and various test scenarios that depend on that issue.
8298f37
to
6a450e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@labkode correct me if I am wrong. The storageprovider is not supposed to deal with cross storageprovider move requests, right? Cross storage moves are a COPY and DELETE operation that will create a new resource with a new fileid. A cross storage move needs to be handled by the client, so that it can notify the user about the change.
That being said, we are planning to be able to move spaces between storage providers if they a able to import ids, which depends on the implementation.
@C0rby can you fix this in the ocdav layer instead of the CS3 gateway?
6a450e2
to
51e11e3
Compare
As the share receiver, moving a shared file to another share was not possible.