Add config to EOS fs for allowing recycle operations on arbitrary paths #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkode
approved these changes
Oct 21, 2021
gmgigi96
pushed a commit
to cernbox/reva
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In EOS fs, if we want to perform recycle operations on arbitrary paths, we check if the current user has appropriate permissions on the path, and if they do, impersonate the owner of the path.
This introduces a security issue that if a user tries to access the recycle bin associated with the path to a folder shared with them, reva will check that the user has access to that path and then allow them to list the recycle bin of the creator of the share. As a protection for this, we introduce a new config variable to allow such operations, so that these can only be enabled for storage providers which support shared spaces and not user homes.