Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority to app providers #2263

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Conversation

gmgigi96
Copy link
Member

Before the order of the list returned by the method FindProviders of app providers depended from the order in which the app provider registered themselves.
Now, it is possible to specify a priority for each app provider, and even if an app provider re-register itself (for example after a restart), the order is kept.

This PR also remove all the code used to keep the default app provider always to the top of the list for each mime type, as now the cs3apis support the field DefaultApplication (#2230 cs3org/cs3apis#157)

@update-docs
Copy link

update-docs bot commented Nov 11, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek
Copy link
Contributor

Code changes look good to me.
But I didn't fully understand the client use case for ordered app lists. How does a client benefit from it? Is is about ordering in the apps menu? (Example from oC Web see screenshot)

image

If that's the case I wonder what happens if all apps have the same priority? Should we then do an alphabetical order, too? Or isn't it up to the client how to sort these apps?

@labkode
Copy link
Member

labkode commented Nov 18, 2021

Code changes look good to me. But I didn't fully understand the client use case for ordered app lists. How does a client benefit from it? Is is about ordering in the apps menu? (Example from oC Web see screenshot)

image

If that's the case I wonder what happens if all apps have the same priority? Should we then do an alphabetical order, too? Or isn't it up to the client how to sort these apps?

@wkloucek the aim here is that the list presented to the user doesn't change as the service restarts to reduce confusion from the end-user perspective.

Imagine, you click and you have "Open in OnlyOffice" as first entry and then when the service restarts you'll have it at the end.

@labkode labkode merged commit a73b194 into cs3org:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants