-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update eos-revad dockerfile #2712
Conversation
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, try keeping the Dockerfile lines under 80 chars to improve readability of the Dockerfile
From https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#env
Using
\
as a line continuation character for Linux Dockerfiles improves readability.
Co-authored-by: Samuel Alfageme <samuel.alfageme@gmail.com>
Just built and checked the compressed size of the image locally: |
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749 could you give a go the
... and report back on the size? |
I added the following line:
in the Dockerfile but the size appears to be the same around ~ |
Let's merge for the time being and fix the size in a follow-up PR |
Updates the dockerfile for
revad-eos
to not break.The compressed size of the image is 2.76GB.
/cc @SamuAlfageme
Signed-off-by: Jimil Desai jimildesai42@gmail.com