File uploaded event in dataprovider #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously emitted them after the InitiateFileUpload call which could lead to the indexer trying to stat the file even though the upload hadn't been finished yet.
The dataprovider uses this callback to emit the FileUploaded event which will be picked up by the search indexer, for example.
aduffeck
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
approved these changes
May 18, 2022
kobergj
reviewed
May 18, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
25 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes a problem with the
FileUploadedevent which has been emitted too early until now.The previous code emitted
FileUploadedafter theInitiateFileUploadcall already, which is too early because the file hasn't actually been uploaded yet at that point and isn't available to be statted yet, for example.The fix is to emit the event from the dataprovider only when the upload has actually finished.
Note: This PR only implements this functionality for the decomposedfs storage driver, other drivers might still need to be adapted.