Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Add blobstore metrics #3272

Merged
merged 6 commits into from
Sep 28, 2022

Conversation

dragonchaser
Copy link

@dragonchaser dragonchaser commented Sep 26, 2022

Enhancement: Add s3ng metrics

We have added rx/tx metrics to the s3ng blobstore driver.

@update-docs
Copy link

update-docs bot commented Sep 26, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser force-pushed the add-blobstore-metric branch 3 times, most recently from ae673c9 to 6dc82d8 Compare September 26, 2022 11:22
@dragonchaser dragonchaser changed the title add blobstore metric add blobstore metrics Sep 26, 2022
@dragonchaser dragonchaser force-pushed the add-blobstore-metric branch 3 times, most recently from 8bd1aef to af8c66c Compare September 26, 2022 12:41
@dragonchaser dragonchaser marked this pull request as ready for review September 26, 2022 12:55
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some open questions

changelog/unreleased/add-s3ng-metrics.md Outdated Show resolved Hide resolved
pkg/storage/fs/s3ng/blobstore/blobstore.go Outdated Show resolved Hide resolved
pkg/storage/fs/s3ng/blobstore/blobstore.go Show resolved Hide resolved
pkg/storage/fs/s3ng/blobstore/metrics.go Outdated Show resolved Hide resolved
@kobergj kobergj changed the title add blobstore metrics [tests-only] Add blobstore metrics Sep 26, 2022
@dragonchaser dragonchaser force-pushed the add-blobstore-metric branch 2 times, most recently from 45a367a to fe7ad1c Compare September 27, 2022 10:14
@fschade
Copy link
Contributor

fschade commented Sep 27, 2022

@labkode, ci seems to be pretty flaky today. Known on your side?

Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser dragonchaser merged commit 44d4607 into cs3org:experimental Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants