-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] Add blobstore metrics #3272
Merged
dragonchaser
merged 6 commits into
cs3org:experimental
from
dragonchaser:add-blobstore-metric
Sep 28, 2022
Merged
[tests-only] Add blobstore metrics #3272
dragonchaser
merged 6 commits into
cs3org:experimental
from
dragonchaser:add-blobstore-metric
Sep 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dragonchaser
force-pushed
the
add-blobstore-metric
branch
3 times, most recently
from
September 26, 2022 11:22
ae673c9
to
6dc82d8
Compare
dragonchaser
force-pushed
the
add-blobstore-metric
branch
3 times, most recently
from
September 26, 2022 12:41
8bd1aef
to
af8c66c
Compare
dragonchaser
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
September 26, 2022 12:55
kobergj
requested changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some open questions
dragonchaser
force-pushed
the
add-blobstore-metric
branch
from
September 26, 2022 13:43
132c648
to
e5a76d1
Compare
kobergj
approved these changes
Sep 26, 2022
dragonchaser
force-pushed
the
add-blobstore-metric
branch
2 times, most recently
from
September 27, 2022 10:14
45a367a
to
fe7ad1c
Compare
@labkode, ci seems to be pretty flaky today. Known on your side? |
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
dragonchaser
force-pushed
the
add-blobstore-metric
branch
from
September 28, 2022 06:38
fe7ad1c
to
1eb6465
Compare
Signed-off-by: Christian Richter <crichter@owncloud.com>
dragonchaser
force-pushed
the
add-blobstore-metric
branch
from
September 28, 2022 07:12
69f8d5a
to
ac0ed8b
Compare
wkloucek
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Add s3ng metrics
We have added rx/tx metrics to the s3ng blobstore driver.