Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: bump alpine base image to v3.17 #3703

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

SamuAlfageme
Copy link
Contributor

@vascoguita
Copy link
Contributor

Could you also update the alpine version in docker/Dockerfile.revad-eos?

@SamuAlfageme
Copy link
Contributor Author

@vascoguita have you tried running an alpine-built revad on CentOS7 successfully after aa93c90 ?

The image built correctly, but there were many static linking issues hard to fix when using alpine rather than the EOS image for the builder step.

@vascoguita
Copy link
Contributor

Oh I see, I'll test it and if it fails I'll try with -extldflags=-static in the ldflags.
Hold on

@SamuAlfageme
Copy link
Contributor Author

@vascoguita I can save you some time if you check #1705 (when I originally used alpine on the builder step) and #1718 (where I restricted the static linking to the build-ci target)

@vascoguita
Copy link
Contributor

vascoguita commented Mar 9, 2023

I've just tested the revad image built from Dockerfile.revad-eos and apparently it's working: https://github.com/vascoguita/reva/actions/runs/4374000858/jobs/7652883570
(Ignore the job name 'docker (docker/Dockerfile.revad) / docker', the steps are building and testing Dockerfile.revad-eos)

@SamuAlfageme
Copy link
Contributor Author

@vascoguita looks promising. I'm not sure to which extent these tests check all the services in reva and how they interact with the eos binary but this might be reviewed in the future if issues arise.

I'll rebase and include it as well on the -eos image. Thanks a lot for checking!

@glpatcern glpatcern merged commit 1f46ca3 into cs3org:master Mar 9, 2023
@SamuAlfageme SamuAlfageme deleted the docker-alpine3.17 branch March 9, 2023 14:19
gmgigi96 pushed a commit to gmgigi96/reva that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants