Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleting spaces #3822

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Fix deleting spaces #3822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5187cdf
Purge metadata before purging the space
aduffeck Apr 27, 2023
9c57e69
Add changelog
aduffeck Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/fix-deleting-spaces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Fix deleting spaces

We fixed a problem when trying to delete spaces.

https://github.com/cs3org/reva/pull/3822
8 changes: 4 additions & 4 deletions pkg/storage/utils/decomposedfs/spaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,13 +629,13 @@ func (fs *Decomposedfs) DeleteStorageSpace(ctx context.Context, req *provider.De
return err
}

// remove space metadata
if err := os.RemoveAll(fs.getSpaceRoot(spaceID)); err != nil {
// invalidate cache
if err := fs.lu.MetadataBackend().Purge(n.InternalPath()); err != nil {
return err
}

// invalidate cache
if err := fs.lu.MetadataBackend().Purge(n.InternalPath()); err != nil {
// remove space metadata
if err := os.RemoveAll(fs.getSpaceRoot(spaceID)); err != nil {
return err
}

Expand Down