Added /app/notify endpoint for logging/tracking apps #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
requested review from
labkode,
wkloucek,
gmgigi96 and
a team
as code owners
|
Don't we have this info in the wopi driver? Like a first request that an app is doing that we can intercept? |
We do, but it turns out it's not enough. This goes with https://its.cern.ch/jira/browse/CERNBOX-3406 and we already have evidence that only the frontend can tell whether the app loaded correctly. |
gmgigi96
approved these changes
Jul 6, 2023
glpatcern
added a commit
to cernbox/reva
that referenced
this pull request
Jul 31, 2023
glpatcern
added a commit
to cernbox/reva
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new endpoint serves to probe the health state of apps such as Microsoft Office Online, and it is expected to be called by the frontend upon successful loading of the document by the underlying app.