Implementation of CS3APIs Locks in the CephFS driver #4280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
ceph-locks
branch
6 times, most recently
from
4f2bd1f
to
cb09a64
Compare
javfg
suggested changes
Oct 25, 2023
gmgigi96
previously approved these changes
Oct 25, 2023
|
Thanks Javi! Will look into this tomorrow once I'm back |
Co-authored-by: Javier Ferrer <javilol@gmail.com>
Co-authored-by: Javier Ferrer <javilol@gmail.com>
Co-authored-by: Javier Ferrer <javilol@gmail.com>
Co-authored-by: Javier Ferrer <javilol@gmail.com>
Co-authored-by: Javier Ferrer <javilol@gmail.com>
javfg
approved these changes
Oct 26, 2023
gmgigi96
approved these changes
Oct 26, 2023
javfg
added a commit
to javfg/reva
that referenced
this pull request
Nov 2, 2023
* Refactoring * Implemented locking for CephFS * Minor alignments in the EOS driver * Cleanup * Alternate implementation of GetLock * Applied suggestions Co-authored-by: Javier Ferrer <javilol@gmail.com> * Applied suggestions Co-authored-by: Javier Ferrer <javilol@gmail.com> * Applied suggestions Co-authored-by: Javier Ferrer <javilol@gmail.com> * Applied suggestions Co-authored-by: Javier Ferrer <javilol@gmail.com> * Applied suggestions Co-authored-by: Javier Ferrer <javilol@gmail.com> * Further fixes --------- Co-authored-by: Javier Ferrer <javilol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation follows the eosfs one, with the notable difference that we use
flockcalls to CephFS. If those locks would follow the POSIX semantic, they would be gone by the time we close the file, which is undesirable here. Will test with WOPI once we put things all together.