-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple templates in config entries #4282
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
271adda
to
5b92432
Compare
83ea584
to
8070c8d
Compare
Not sure why integration tests fail, especially as the logs show |
@glpatcern Try to run it locally. You will have also the reva logs to understand why. Just type |
For the record, to be looked at: The reva gateway panics in the
Relevant stack trace:
|
3da9dd4
to
1620ff3
Compare
1620ff3
to
73db074
Compare
This reverts commit bd13e11.
Somehow surprisingly, fixing a flaw in the logic (a not found key should not be replaced) fixed all the scenarios. The PR is ready for review. |
This PR introduces support for config entries with multiple templates, such as
parameter = "{{ vars.v1 }} foo {{ vars.v2 }}"
.Previously, only one
{{ template }}
was allowed in a given configuration entry.